fix(plugins): harden sidebar plugin loading and API checks#1977
Merged
bajrangCoder merged 1 commit intoAcode-Foundation:mainfrom Mar 24, 2026
Merged
Conversation
Contributor
Greptile SummaryThis PR hardens the sidebar plugin loading logic in Key changes:
Confidence Score: 5/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[searchPlugin / loadExplore triggered] --> B{await checkAPIStatus}
B -- false --> C[Show api_error UI and return]
B -- true --> D[Fetch plugins from API]
D --> E[Call listInstalledPlugins]
E --> F[await lsDir — unguarded]
F --> G{For each item}
G --> H{Read plugin.json}
H -- error --> I[warn + return null]
H -- ok --> J{plugin.icon exists?}
J -- no --> K[Set installed=true, return plugin]
J -- yes --> L{toInternalUri}
L -- error --> M[warn, keep original icon path]
L -- ok --> N[Set resolved icon]
M --> K
N --> K
G --> G
E --> O[filter out nulls]
O --> P[Render plugin list items]
Reviews (1): Last reviewed commit: "fix(plugins): harden sidebar plugin load..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.